squah-confluent commented on code in PR #21013:
URL: https://github.com/apache/kafka/pull/21013#discussion_r2580486043
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -21009,6 +21009,90 @@ fooTopicName, computeTopicHash(fooTopicName,
metadataImage)
tasks
);
}
+
+ @Test
+ public void testConsumerGroupMemberJoinsWithNonEmptyRegexToEmptyRegex() {
Review Comment:
We aren't really joining a new member in this test, only updating an
existing member. Maybe we could we rename this to
`testConsumerGroupMemberClearsRegex` and move it after
`testConsumerGroupMemberJoinRefreshesExpiredRegexes`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]