chia7712 commented on code in PR #19566:
URL: https://github.com/apache/kafka/pull/19566#discussion_r2613862984
##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -966,7 +966,12 @@ private[kafka] class Processor(
tryUnmuteChannel(channelId)
case response: SendResponse =>
- sendResponse(response, response.responseSend)
+ try
+ sendResponse(response, response.responseSend)
+ finally {
+ if (response.request.header.apiKey().forwardable)
Review Comment:
We should release the buffer only if it is NOT forwardable, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
