m1a2st commented on code in PR #21176:
URL: https://github.com/apache/kafka/pull/21176#discussion_r2646419222
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/ProducerStateManagerTest.java:
##########
@@ -1090,6 +1090,27 @@ public void testVerificationStateEntryExpiration() {
assertNull(stateManager.verificationStateEntry(producerId));
}
+ @Test
+ public void testIdempotentTransactionMarkerExceptionThrownTV2() {
+ short transactionVersion = 2;
+ appendClientEntry(stateManager, producerId, epoch, defaultSequence,
99, true);
+ assertEquals(OptionalLong.of(99L),
stateManager.firstUndecidedOffset());
+
+ short markerEpoch = (short) (epoch + 1);
+ appendEndTxnMarker(stateManager, producerId, markerEpoch,
ControlRecordType.COMMIT, 100, transactionVersion);
Review Comment:
Thanks for pointing out! Updated to use the helper method consistently for
both appends. This ensures the full cleanup steps are executed and makes the
test clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
