ahuang98 commented on code in PR #21221:
URL: https://github.com/apache/kafka/pull/21221#discussion_r2709367767
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1194,6 +1201,14 @@ ControllerResult<AlterPartitionResponseData>
alterPartition(
return ControllerResult.of(records, response);
}
+ private static String logPartitionChangeInfo(PartitionRegistration
oldRegistration, PartitionRegistration newRegistration) {
+ return String.format("isr: %s -> %s, replicaSet: %s -> %s,
partitionEpoch: %d -> %d, leaderEpoch: %d -> %d",
Review Comment:
will keep this in mind, I had thought preference might be to indicate if the
value is expected to be an int type or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
