devtrace404 commented on code in PR #21198:
URL: https://github.com/apache/kafka/pull/21198#discussion_r2724783913
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -221,13 +238,24 @@ boolean doSend(final UnsentRequest r, final long
currentTimeMs) {
log.debug("No broker available to send the request: {}.
Retrying.", r);
return false;
}
+
+ // Check if we're still in backoff period for this node
+ long backoffDelay = getBackoffDelay(node, currentTimeMs);
+ if (backoffDelay > 0) {
+ // Still in backoff period, skip retry
+ return false;
Review Comment:
@kirktrue @lianetm That is a fair point. Since the `ready()` method returns
false for various conditions (metadata update in progress, too many in-flight
requests, connecting state) and these shouldn't all be treated uniformly with
backoff. They could be transient and must not have delay. I have eliminated the
log spam with TRACE logs. Let me know if that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
