AndrewJSchofield commented on code in PR #21385:
URL: https://github.com/apache/kafka/pull/21385#discussion_r2769524723
##########
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##########
@@ -388,8 +386,7 @@ object ConfigCommand extends Logging {
case ClientMetricsType =>
adminClient.listConfigResources(java.util.Set.of(ConfigResource.Type.CLIENT_METRICS),
new ListConfigResourcesOptions).all().get().asScala.map(_.name).toSeq
case GroupType =>
- adminClient.listGroups().all.get.asScala.map(_.groupId).toSet ++
-
adminClient.listConfigResources(java.util.Set.of(ConfigResource.Type.GROUP),
new ListConfigResourcesOptions).all().get().asScala.map(_.name).toSet
+ adminClient.listGroups().all.get.asScala.map(_.groupId).toSet ++
listGroupConfigResources(adminClient).map(resources =>
resources.asScala.map(_.name).toSet).getOrElse(Set() ++ entityName)
Review Comment:
True. I do speak Scala like it's a foreign language unfortunately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
