chia7712 commented on code in PR #21385:
URL: https://github.com/apache/kafka/pull/21385#discussion_r2769620836


##########
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##########
@@ -537,6 +534,21 @@ object ConfigCommand extends Logging {
     
adminClient.describeClientQuotas(ClientQuotaFilter.containsOnly(components.asJava)).entities.get(30,
 TimeUnit.SECONDS).asScala
   }
 
+  private def listGroupConfigResources(adminClient: Admin): 
Option[java.util.Collection[ConfigResource]] = {
+    try {

Review Comment:
   @AndrewJSchofield are you happy with this comment ? :smile: 
   
   the latest commit 
https://github.com/apache/kafka/pull/21385/commits/d917d47b6c0fa5ebed207625f8a846d7c32c3f62
 seems to not handle this comment 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to