chia7712 commented on code in PR #21384:
URL: https://github.com/apache/kafka/pull/21384#discussion_r2770443380
##########
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##########
@@ -79,6 +79,7 @@ public abstract class AbstractKafkaConfig extends
AbstractConfig {
QuorumConfig.CONFIG_DEF,
MetricConfigs.CONFIG_DEF,
QuotaConfig.CONFIG_DEF,
+ QuotaConfig.BROKER_QUOTA_CONFIG_DEF,
Review Comment:
> they won't be in the section [1]? So that's basically correct?
I think it's still beneficial to document them. The updates in KAFKA-20125
will remind users that these configs are dynamic-only. We could modify the
config generation logic instead of adding them to
`AbstractKafkaConfig.CONFIG_DEF`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
