chia7712 commented on code in PR #21384:
URL: https://github.com/apache/kafka/pull/21384#discussion_r2770511835
##########
server-common/src/main/java/org/apache/kafka/server/config/QuotaConfig.java:
##########
@@ -212,17 +224,7 @@ public int controllerQuotaWindowSizeSeconds() {
}
public static ConfigDef brokerQuotaConfigs() {
- return new ConfigDef()
- // Round minimum value down, to make it easier for users.
- .define(QuotaConfig.LEADER_REPLICATION_THROTTLED_RATE_CONFIG,
ConfigDef.Type.LONG,
- QuotaConfig.QUOTA_BYTES_PER_SECOND_DEFAULT,
ConfigDef.Range.atLeast(0),
- ConfigDef.Importance.MEDIUM,
QuotaConfig.LEADER_REPLICATION_THROTTLED_RATE_DOC)
-
.define(QuotaConfig.FOLLOWER_REPLICATION_THROTTLED_RATE_CONFIG,
ConfigDef.Type.LONG,
- QuotaConfig.QUOTA_BYTES_PER_SECOND_DEFAULT,
ConfigDef.Range.atLeast(0),
- ConfigDef.Importance.MEDIUM,
QuotaConfig.FOLLOWER_REPLICATION_THROTTLED_RATE_DOC)
-
.define(QuotaConfig.REPLICA_ALTER_LOG_DIRS_IO_MAX_BYTES_PER_SECOND_CONFIG,
ConfigDef.Type.LONG,
- QuotaConfig.QUOTA_BYTES_PER_SECOND_DEFAULT,
ConfigDef.Range.atLeast(0),
- ConfigDef.Importance.MEDIUM,
QuotaConfig.REPLICA_ALTER_LOG_DIRS_IO_MAX_BYTES_PER_SECOND_DOC);
+ return BROKER_QUOTA_CONFIG_DEF;
Review Comment:
> I don't get why we have just 3 properties, which are configured only
dynamically. Why not also dual-mode (i.e., static || dynamic)? Like for
instance num.io.threads works fine in dual-mode but probably I should read a
KIP, which introduced those properties... but it's bit weird.
You might want to check out the
[KIP-1051](https://cwiki.apache.org/confluence/x/C4xyEg), which address the
exact issue
> At least I think we should add comment here that in such line
DynamicConfig.java#L36 those configs are dynamic-only and not dual-mode as
others.
Actually, the comment is already there. see
https://github.com/apache/kafka/blob/trunk/server/src/main/java/org/apache/kafka/server/config/DynamicConfig.java#L27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
