lianetm commented on PR #21412: URL: https://github.com/apache/kafka/pull/21412#issuecomment-3855758113
Agree, but just to make sure I'm following. The fact that this `TimestampType` is public makes the package public already, correct? we can already see the package exposed in the java docs for ConsumerRecord, but without link (this is why I found this btw) https://kafka.apache.org/40/javadoc/org/apache/kafka/clients/consumer/ConsumerRecord.html That being said, totally agree that the situation of this package is a mix of private and public components. As alternative to the KIP path, could we also consider leaving the public `TimestampType` where it is (class and package are public),and move all the private classes instead? (to an "internal" folder maybe, that wouldn't be part of the public API) We have a similar structure for the consumer, this https://github.com/apache/kafka/tree/trunk/clients/src/main/java/org/apache/kafka/clients/consumer wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
