AndrewJSchofield commented on PR #21412: URL: https://github.com/apache/kafka/pull/21412#issuecomment-3856491504
> > could we also consider leaving the public TimestampType where it is (class and package are public),and move all the private classes instead? (to an "internal" folder maybe, that wouldn't be part of the public API) We have a similar structure for the consumer, this https://github.com/apache/kafka/tree/trunk/clients/src/main/java/org/apache/kafka/clients/consumer > > That is a practical idea to avoid a KIP. My concern, however, is that it leaves `org.apache.kafka.common.record` with only a single class. That feels a bit odd for a public package structure True, but this stuff is all a bit of a mess to be honest. That doesn't seem too bad to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
