dajac opened a new pull request, #21437: URL: https://github.com/apache/kafka/pull/21437
Methods returning CompletableFuture should not throw synchronous exceptions. Callers expect all errors to be delivered through the future, not as synchronous exceptions. This change wraps the method bodies of scheduleWriteOperation, scheduleReadOperation, scheduleTransactionalWriteOperation, and scheduleTransactionCompletion in try-catch blocks to ensure all exceptions are captured in failed futures. For scheduleWriteAllOperation and scheduleReadAllOperation, the throwIfNotRunning() call is removed since they delegate to the single-operation methods which now handle errors properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
