mjsax commented on PR #21304: URL: https://github.com/apache/kafka/pull/21304#issuecomment-3875346533
> but from my perspective that's about trade-off. Yes, 100% agreed :) > TBH the best solution I think would be to use sealed interface, but they are coming with Java 17+ Also agreed :) It's a subjective question, and your arguments are valid. The question is really, is the squeeze worth the juice? It seems, that we did miss (at least, it was not discussed) the interface solution during the original KIP. Now we have existing code for almost 4 years, and no problems. -- Maybe the interface solution is somewhat better, but as you also said, it's not ideal either. So is the gain worth doing a KIP and adding all the deprecation noise to the API. Personally, I would just leave it as-is for now, an revisit at some point in the future when we get to Java 17 (we can put a not on the Jira ticket and leave it open until than)? We have more KIPs and PRs to review than we can process in a timely manner, so I would put this one into the very lowest importance category, and thus, recommend to not invest any more time at this point. It's of course just my personal opinion, and if you feel strong about it, I cannot prevent you from writing a KIP and proposing it. Maybe some other committers find it more valuable than I do, and help you to get the KIP accepted and a PR merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
