aliehsaeedii commented on code in PR #21408:
URL: https://github.com/apache/kafka/pull/21408#discussion_r2786277415
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/HeadersDeserializer.java:
##########
@@ -86,4 +86,10 @@ public Headers deserialize(final String topic, final byte[]
data) {
return headers;
}
+
+ public static Headers deserialize(final byte[] data) {
Review Comment:
>can't the caller code not just create an instance of HeaderDeserializer
what is the reason that you prefer non-static? I'm OK, just as learning
purpose I ask. If the caller class needs to call it even only once, it needs to
create an instance and then call it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
