mjsax commented on code in PR #21408:
URL: https://github.com/apache/kafka/pull/21408#discussion_r2789597205
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/HeadersDeserializer.java:
##########
@@ -86,4 +86,10 @@ public Headers deserialize(final String topic, final byte[]
data) {
return headers;
}
+
+ public static Headers deserialize(final byte[] data) {
Review Comment:
> If the caller class needs to call it even only once, it needs to create an
instance and then call it.
That's the question. Do we have such a case? -- My understanding would be,
that a caller would need to use it regularly, and thus we would "trash" GC
(even if not super expensive for very short lived object) using a static
method, and it seems better if the caller uses a single long live instance of
`HeaderDeserializer`?
We can of course also keep it for now and see how it goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
