m1a2st commented on code in PR #21484:
URL: https://github.com/apache/kafka/pull/21484#discussion_r2820478496
##########
clients/src/main/java/org/apache/kafka/clients/admin/ClassicGroupDescription.java:
##########
@@ -91,23 +122,21 @@ public String groupId() {
}
/**
- * The group protocol type.
+ * The group protocol type, or the empty string.
*/
public String protocol() {
return protocol;
}
/**
- * The group protocol data. The meaning depends on the group protocol type.
- * For a classic consumer group, this is the partition assignor name.
- * For a classic connect group, this indicates which Connect protocols are
enabled.
+ * The group protocol data.
Review Comment:
I moved these comments to the class level, but I think it’s also fine to
keep them here. Therefore, I will revert this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
