m1a2st commented on code in PR #21484:
URL: https://github.com/apache/kafka/pull/21484#discussion_r2820517730


##########
clients/src/main/java/org/apache/kafka/clients/admin/ClassicGroupDescription.java:
##########
@@ -91,23 +122,21 @@ public String groupId() {
     }
 
     /**
-     * The group protocol type.
+     * The group protocol type, or the empty string.

Review Comment:
   When I traced the code path for setting the protocol type, I found that it 
is translated as `group.protocolType().orElse("")`. so null is prevented at the 
call site.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to