see-quick commented on code in PR #21406: URL: https://github.com/apache/kafka/pull/21406#discussion_r2828265458
########## storage/src/test/java/org/apache/kafka/storage/internals/log/LogCleanerLagIntegrationTest.java: ########## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.storage.internals.log; + +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.compress.Compression; +import org.apache.kafka.common.record.internal.CompressionType; +import org.apache.kafka.common.record.internal.Record; +import org.apache.kafka.server.util.MockTime; + +import org.junit.jupiter.api.Tag; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.EnumSource; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.Arrays; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * This is an integration test that tests the fully integrated log cleaner + */ +@Tag("integration") +public class LogCleanerLagIntegrationTest extends AbstractLogCleanerIntegrationTest { Review Comment: Okay before I proceed ... so what do we want? :D I don't care much which approach we choose :) Both ideas are good... but I think for maybe future it's better to de-couple stuff (i.e., having fixtures and dedicated tests which using those fixtures)? I know that there are plenty test classes which having more that 3k LOCs :D so having 700 LOC is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
