lucliu1108 commented on code in PR #21508:
URL: https://github.com/apache/kafka/pull/21508#discussion_r2833712464
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroupMember.java:
##########
@@ -66,6 +69,8 @@ public static class Builder {
private Map<Uuid, Set<Integer>> assignedPartitions = Map.of();
private Map<Uuid, Set<Integer>> partitionsPendingRevocation = Map.of();
private ConsumerGroupMemberMetadataValue.ClassicMemberMetadata
classicMemberMetadata = null;
+ private Map<Uuid, Map<Integer, Integer>> assignedPartitionsWithEpochs
= Map.of();
Review Comment:
I have removed all setters for `assignedPartitions` and
`partitionsPendingRevocation`, but still keep the getters and as private fields
to avoid redundant conversions in other methods that previously call these
getters.
Since these private fields will be re-constructed every time the builder is
called to set `assignedPartitionsWithEpochs` and
`partitionsRevocationsWithEpochs`, the getters won't be async.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
