lucliu1108 commented on code in PR #21508:
URL: https://github.com/apache/kafka/pull/21508#discussion_r2835160412
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroupMember.java:
##########
@@ -66,6 +69,8 @@ public static class Builder {
private Map<Uuid, Set<Integer>> assignedPartitions = Map.of();
private Map<Uuid, Set<Integer>> partitionsPendingRevocation = Map.of();
private ConsumerGroupMemberMetadataValue.ClassicMemberMetadata
classicMemberMetadata = null;
+ private Map<Uuid, Map<Integer, Integer>> assignedPartitionsWithEpochs
= Map.of();
Review Comment:
For the `assignedPartitions`, it is part of the fields inherited from
`ModernGroupMember` that `ShareGroupMember` also uses, so i left it there for
the getter method.
Or another way is not to initialize it in the constructor (keep it null?)
but maybe this is not good practice.
For the. `partitionsPendingRevocation`, there are 6 or 7 places it is
directly called. Guess I could remove this method and do extra conversions for
where its' called instead, or use a view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
