brandboat commented on code in PR #21607:
URL: https://github.com/apache/kafka/pull/21607#discussion_r2870218307
##########
metadata/src/main/java/org/apache/kafka/metadata/ListenerInfo.java:
##########
@@ -134,7 +134,7 @@ public static ListenerInfo fromControllerRegistrationRecord(
* @return The ListenerInfo object.
*/
public static ListenerInfo fromBrokerRegistrationRequest(
- BrokerRegistrationRequestData.ListenerCollection collection
+ List<BrokerRegistrationRequestData.Listener> collection
) {
LinkedHashMap<String, Endpoint> listeners = new LinkedHashMap<>();
Review Comment:
Thanks for the clarification! I hadn't noticed that before. I'm ok to close
out the PR. One thing to point out is that ImplicitLinkedHashMultiCollection
seems to only provide reference equality, rather than deep equality for
elements.
If we want to enforce unique listener names at the RPC layer, we still need
explicit validation, right? Or am I missing something? Is reference equality
sufficient here?
https://github.com/apache/kafka/blob/c77a96d13238c3127dc8cf016d437efb5e64bfa9/clients/src/main/java/org/apache/kafka/common/utils/ImplicitLinkedHashMultiCollection.java#L32-L35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
