chia7712 commented on code in PR #21607:
URL: https://github.com/apache/kafka/pull/21607#discussion_r2879657846


##########
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##########
@@ -34,7 +34,7 @@
       "about": "The incarnation id of the broker process." },
     { "name": "Listeners", "type": "[]Listener",
       "about": "The listeners of this broker.", "versions": "0+", "fields": [
-      { "name": "Name", "type": "string", "versions": "0+", "mapKey": true,
+      { "name": "Name", "type": "string", "versions": "0+",

Review Comment:
   Maybe we should close this PR. My main reason for modifying the protocol was 
immutability, but I feel consistency is more important now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to