mjsax commented on code in PR #21580:
URL: https://github.com/apache/kafka/pull/21580#discussion_r2887483817
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreWithHeadersBuilder.java:
##########
@@ -72,7 +72,11 @@ public TimestampedWindowStoreWithHeaders<K, V> build() {
if (!(store instanceof HeadersBytesStore)) {
if (store.persistent()) {
- store = new TimestampedToHeadersWindowStoreAdapter(store);
+ if (store instanceof TimestampedBytesStore) {
+ store = new TimestampedToHeadersWindowStoreAdapter(store);
+ } else {
+ store = new PlainToHeadersWindowStoreAdapter(store);
Review Comment:
Same question: do we actually need this for the window-store case? I though
we only need it for kv-store case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
