mjsax commented on code in PR #21580:
URL: https://github.com/apache/kafka/pull/21580#discussion_r2887493506
##########
streams/src/main/java/org/apache/kafka/streams/state/BuiltInDslStoreSuppliers.java:
##########
@@ -63,7 +63,7 @@ public WindowBytesStoreSupplier windowStore(final
DslWindowParams params) {
}
if (params.isTimestamped()) {
- return Stores.persistentTimestampedWindowStore(
+ return Stores.persistentTimestampedWindowStoreWithHeaders(
Review Comment:
Why is it correct to return a headers-supplier if `params` request a
timestamped one? Don't we need to have a `switch(...)` here, similar to
`keyValueStore` from above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
