clolov commented on code in PR #21627:
URL: https://github.com/apache/kafka/pull/21627#discussion_r2895530387
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -93,6 +113,10 @@ public final class GroupConfig extends AbstractConfig {
public final String shareAutoOffsetReset;
+ public final int shareAssignmentIntervalMs;
+
+ public final Optional<Boolean> shareAssignorOffloadEnable;
Review Comment:
I was thinking a bit more about this! In other configurations (and correct
me if there is a precedent for this), we tend to treat a presence at a
more-granular level as an override of the coarser level. As such, if I don't
want an override at a group-level in this case, I would omit setting the
configuration rather than set it as -1. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
