squah-confluent commented on code in PR #21627:
URL: https://github.com/apache/kafka/pull/21627#discussion_r2896370796
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -93,6 +113,10 @@ public final class GroupConfig extends AbstractConfig {
public final String shareAutoOffsetReset;
+ public final int shareAssignmentIntervalMs;
+
+ public final Optional<Boolean> shareAssignorOffloadEnable;
Review Comment:
I see! I got something to work.
The group-level defaults must never be used for the new configs. If we use
the default value (or the values returned by
`GroupCoordinatorConfig.extractGroupConfigMap`), the defaults will be baked in
once any unrelated group-level config is set. Then we won't pick up
`assignment.interval.ms` changes at the group coordinator-level. It's fine for
the other configs since their group coordinator-level configs aren't dynamic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
