akhileshchg commented on code in PR #21654:
URL: https://github.com/apache/kafka/pull/21654#discussion_r2898344529
##########
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##########
@@ -499,8 +510,10 @@ static String
replicaMoveStatesToString(Map<TopicPartitionReplica, LogDirMoveSta
private static void clearAllThrottles(Admin adminClient,
Review Comment:
`executeAssignment` won't call clearAllThrottles. Only `--verify` does. If
the intent is also to remove timeouts in `--verify`, please update the PR
description.
Also, I think the PR is specifically to handle the cases when the few
sources brokers are down and not actually the target brokers (because we do run
verifyBrokerIds). This is also not clear in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
