akhileshchg commented on code in PR #21654:
URL: https://github.com/apache/kafka/pull/21654#discussion_r2898462039
##########
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##########
@@ -1192,8 +1207,15 @@ static void modifyInterBrokerThrottle(Admin adminClient,
Set<Integer> reassigningBrokers,
long interBrokerThrottle) throws
ExecutionException, InterruptedException {
if (interBrokerThrottle >= 0) {
+ Set<Integer> liveBrokers = getLiveBrokerIds(adminClient);
Review Comment:
For one execute command, we're calling describe RPC twice for
InterBrokerThrottle and LogDirThrottle. We should call this once in the parent
executeAssignment method and pass it down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
