aliehsaeedii commented on PR #21743:
URL: https://github.com/apache/kafka/pull/21743#issuecomment-4060593646
> Yes, I had the same thought about removing tests even before I read you
comment. We can do a follow up PR or add here. Whatever you prefer.
>
> As a matter of fact, I am even wondering if we need to add all these
sub-classes of the GenericXxx classes? How often do we use these sub-classes As
you test code shows, we can easily instantiate GenericXxx directly, so I am
wondering if we gain much by having all the sub-classes or if we could drop
them, and let each user just use GenericXxx directly?
The only real benefit of the subclasses is for TopologyTestDriver
inheritance:
- TopologyTestDriver.KeyValueStoreFacade extends
ReadOnlyKeyValueStoreFacade
- It needs the protected TimestampedKeyValueStore<K, V> inner field to
call write methods
But you are right, we could refactor this pattern to use composition
instead of inheritance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
