mjsax commented on code in PR #21743:
URL: https://github.com/apache/kafka/pull/21743#discussion_r2935622766
##########
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java:
##########
@@ -1280,10 +1281,49 @@ public void waitObject(final Object obj, final
Supplier<Boolean> condition, fina
}
}
- static class KeyValueStoreFacade<K, V> extends
ReadOnlyKeyValueStoreFacade<K, V> implements KeyValueStore<K, V> {
+ static class KeyValueStoreFacade<K, V> implements KeyValueStore<K, V> {
+ private final TimestampedKeyValueStore<K, V> inner;
+ private final GenericReadOnlyKeyValueStoreFacade<K,
ValueAndTimestamp<V>, V> readFacade;
Review Comment:
I don't think we need to have this as a member, but `KeyValueStoreFacade`
can just inherit from `GenericReadOnlyKeyValueStoreFacade` directly.
I am going to just push a change for this (also removing unnecessary test --
don't need to re-test what we inherit from `GenericReadOnlyKeyValueStoreFacade`
in `KeyValueStoreFacadeTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
