UladzislauBlok commented on code in PR #21755:
URL: https://github.com/apache/kafka/pull/21755#discussion_r2936484529
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/WindowedSerializer.java:
##########
@@ -16,10 +16,11 @@
*/
package org.apache.kafka.streams.kstream.internals;
+import org.apache.kafka.common.header.Headers;
import org.apache.kafka.common.serialization.Serializer;
import org.apache.kafka.streams.kstream.Windowed;
public interface WindowedSerializer<T> extends Serializer<Windowed<T>> {
- byte[] serializeBaseKey(String topic, Windowed<T> data);
+ byte[] serializeBaseKey(String topic, Headers headers, Windowed<T> data);
Review Comment:
I had the same thought when making the change, but I decided that since this
interface is effectively internal (even though the method is public), we're
free to change it. If we want to treat it as a public API, we'd definitely need
to add a default method instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
