mjsax commented on code in PR #21755:
URL: https://github.com/apache/kafka/pull/21755#discussion_r2937173849
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/WindowedSerializer.java:
##########
@@ -16,10 +16,11 @@
*/
package org.apache.kafka.streams.kstream.internals;
+import org.apache.kafka.common.header.Headers;
import org.apache.kafka.common.serialization.Serializer;
import org.apache.kafka.streams.kstream.Windowed;
public interface WindowedSerializer<T> extends Serializer<Windowed<T>> {
- byte[] serializeBaseKey(String topic, Windowed<T> data);
+ byte[] serializeBaseKey(String topic, Headers headers, Windowed<T> data);
Review Comment:
Yes, but the problem is, that `serializeBaseKey` is inherited by public
classes `TimeWindowedSerializer` and `SessionWindowedSerializer`, and thus this
method is (unintentionally) part of the public API, even if this interface
itself is not public :(
That's why I filed KAFKA-20313...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
