lianetm commented on code in PR #21495:
URL: https://github.com/apache/kafka/pull/21495#discussion_r2942780100
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -1227,11 +1236,24 @@ private CompletableFuture<Void> assignPartitions(
return result;
}
+ /**
+ * Returns true if assignment changes can happen outside of
consumer.poll().
+ * When false, the assignment update will be deferred to the application
thread and applied
+ * during poll, ensuring that consumer.assignment() only changes within a
call to consumer.poll().
+ *
+ * @return true if assignment changes can happen outside poll, false to
defer to poll
+ */
+ protected abstract boolean allowAssignmentChangeOutsidePoll();
Review Comment:
nice simplification, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
