lianetm commented on PR #21495: URL: https://github.com/apache/kafka/pull/21495#issuecomment-4070440967
Comments addressed @lucasbru . About the general ones: > We should be able to implement it exactly the same way in StreamsMembershipManager, can we include it as well? Sure, will open it in a separate PR right after this one for KS (tried it already but mixes in KS manager/event/tests so seems better separately) > Why not just call the callback from the PartitionsAssignedEvent? uhm that's what we do already. Callback directly called from the process(PartitionsAssignedEvent) https://github.com/lianetm/kafka/blob/ea93e7442e97533d8fb993786b19eeef1d81be35/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java#L243 . Do you mean something else? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
