mjsax commented on code in PR #21737:
URL: https://github.com/apache/kafka/pull/21737#discussion_r2944896636
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8804,7 +8815,12 @@ private Map<String, String>
streamsGroupAssignmentConfigs(String groupId) {
Optional<GroupConfig> groupConfig =
groupConfigManager.groupConfig(groupId);
final Integer numStandbyReplicas =
groupConfig.map(GroupConfig::streamsNumStandbyReplicas)
.orElse(config.streamsGroupNumStandbyReplicas());
- return Map.of("num.standby.replicas", numStandbyReplicas.toString());
+ final Integer taskOffsetIntervalMs =
groupConfig.map(GroupConfig::streamsTaskOffsetIntervalMs)
+ .orElse(config.streamsGroupTaskOffsetIntervalMs());
+ return new TreeMap<>(Map.of(
+ "num.standby.replicas", numStandbyReplicas.toString(),
+ "task.offset.interval.ms", taskOffsetIntervalMs.toString()
Review Comment:
Oh. I see. No, the assignor should not make a different decision. The impact
of this change was not clear to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
