mjsax commented on code in PR #21737:
URL: https://github.com/apache/kafka/pull/21737#discussion_r2944905680
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8804,7 +8815,12 @@ private Map<String, String>
streamsGroupAssignmentConfigs(String groupId) {
Optional<GroupConfig> groupConfig =
groupConfigManager.groupConfig(groupId);
final Integer numStandbyReplicas =
groupConfig.map(GroupConfig::streamsNumStandbyReplicas)
.orElse(config.streamsGroupNumStandbyReplicas());
- return Map.of("num.standby.replicas", numStandbyReplicas.toString());
+ final Integer taskOffsetIntervalMs =
groupConfig.map(GroupConfig::streamsTaskOffsetIntervalMs)
+ .orElse(config.streamsGroupTaskOffsetIntervalMs());
+ return new TreeMap<>(Map.of(
+ "num.standby.replicas", numStandbyReplicas.toString(),
+ "task.offset.interval.ms", taskOffsetIntervalMs.toString()
Review Comment:
I'll keep the `TreeMap` as we need to add `max.warmu.task` config later
here... The `TreeMap` is needed to keep things ordered -- otherwise tests have
a hard time to compare expected results, as maps get translated into lists, and
w/o tree-map the data might end up in different order making test fail even if
they are actually correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
