chia7712 commented on code in PR #22229:
URL: https://github.com/apache/kafka/pull/22229#discussion_r3203746158
##########
build.gradle:
##########
@@ -4067,6 +4075,13 @@ gradle.projectsEvaluated {
ERROR: Dependency on :clients test output is not allowed.
Found in project ${proj.path} configuration '${config.name}'.
Use `testFixtures(project(':clients'))` instead of
`project(':clients').sourceSets.test.output`
+""")
+ }
+ if
(file.absolutePath.endsWith('/server-common/build/classes/java/test')) {
Review Comment:
Would you mind using array to eliminate duplicate code?
##########
build.gradle:
##########
@@ -4214,7 +4229,7 @@ def verifyVersionConsistencyTask =
tasks.register('verifyVersionConsistency') {
// Check if regex matches current content "as is"
// Note: We need to see if the file content *already* matches what we
want it to be.
// One way is to simulate the replacement and see if it changes nothing.
-
+
Review Comment:
please revert unrelated changes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
