chia7712 commented on code in PR #22229:
URL: https://github.com/apache/kafka/pull/22229#discussion_r3210234634
##########
build.gradle:
##########
@@ -2260,6 +2262,12 @@ project(':server-common') {
implementation libs.pcollections
implementation libs.slf4jApi
+ testFixturesImplementation testFixtures(project(':clients'))
+ testFixturesApi libs.slf4jApi
Review Comment:
Could we try using testFixturesImplementation instead of testFixturesApi?
It's generally a best practice to let downstream modules explicitly declare
their own dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
