m1a2st commented on code in PR #22243:
URL: https://github.com/apache/kafka/pull/22243#discussion_r3212925347
##########
build.gradle:
##########
@@ -1947,12 +1946,13 @@ project(':clients') {
compileOnly libs.jacksonJDK8Datatypes
compileOnly libs.jose4j // for SASL/OAUTHBEARER JWT validation;
only used by broker
- testFixturesApi project(':test-common:test-common-util')
+ testFixturesImplementation project(':test-common:test-common-util')
testFixturesApi libs.bcpkix
Review Comment:
No, the remaining four declarations should all stay as testFixturesApi — all
of them expose library types in public method signatures of the test fixtures,
so consumers need them transitively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
