chia7712 commented on code in PR #22243:
URL: https://github.com/apache/kafka/pull/22243#discussion_r3213298831
##########
build.gradle:
##########
@@ -1946,12 +1946,16 @@ project(':clients') {
compileOnly libs.jacksonJDK8Datatypes
compileOnly libs.jose4j // for SASL/OAUTHBEARER JWT validation;
only used by broker
- testFixturesApi project(':test-common:test-common-util')
- testFixturesApi libs.bcpkix
- testFixturesApi libs.junitJupiter
- testFixturesApi libs.jqwik
- testFixturesApi testLog4j2Libs
+ testFixturesImplementation project(':test-common:test-common-util')
+ testFixturesImplementation libs.bcpkix
+ testFixturesImplementation libs.junitJupiter
+ testFixturesImplementation libs.jqwik
Review Comment:
It seems jqwik doesn't need to be in testImplementation here, as
ArbitraryMemoryRecords is only used by the raft module. Should we move
ArbitraryMemoryRecords to the raft module instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
