smjn commented on code in PR #22241:
URL: https://github.com/apache/kafka/pull/22241#discussion_r3218754277
##########
server-common/src/main/java/org/apache/kafka/server/share/dlq/ShareGroupDLQStateManager.java:
##########
@@ -149,12 +214,44 @@ private static class SendThread extends
InterBrokerSendThread {
@Override
public Collection<RequestAndCompletionHandler> generateRequests() {
+ if (!queue.isEmpty()) {
+ ShareGroupDLQStateManager.ShareGroupDLQStateManagerHandler
handler = queue.poll();
+ if (!handler.dlqTopicExists()) {
+ Node randomNode = randomNode();
+ if (randomNode == Node.noNode()) {
+ log.error("Unable to find node to use for coordinator
lookup.");
Review Comment:
Hi,
Yes correct, this is place holder code in case the DLQ topic **does not
exist and auto create is enabled**. In that case network client will send an
RPC to create the topic. The logic will be added as subsequent PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
