AndrewJSchofield commented on code in PR #22241:
URL: https://github.com/apache/kafka/pull/22241#discussion_r3218977502
##########
server-common/src/main/java/org/apache/kafka/server/share/dlq/ShareGroupDLQStateManager.java:
##########
@@ -145,10 +146,17 @@ public Optional<Throwable> validateDlqTopic() {
String topicName = topicNameOpt.get();
+ // Verify that DLQ is enabled on a correctly named topic,
configured on a share group.
if (cacheHelper.containsTopic(topicName) &&
!cacheHelper.isDlqEnabledOnTopic(topicName)) {
return Optional.of(new ConfigException("DLQ is not enabled on
configured DLQ topic for share group " + param.groupId() + " topic: ." +
topicName));
}
+ // Verify that for a non-existent correctly named DLQ topic, auto
create should be enabled.
+ if (!cacheHelper.containsTopic(topicName) &&
!cacheHelper.isDlqAutoTopicCreateEnabled()) {
+ return Optional.of(new ConfigException("DLQ topic does not
exist and auto create is disabled on cluster for share group " +
param.groupId() + "topic: ." + topicName));
Review Comment:
The punctuation and spacing in this log line is a bit odd. The group ID will
immediately be followed by `"topic:."` (no space) and then the topic name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
