mannoopj commented on code in PR #20707:
URL: https://github.com/apache/kafka/pull/20707#discussion_r3242055729
##########
metadata/src/test/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadataTest.java:
##########
@@ -58,27 +53,27 @@ public class BootstrapMetadataTest {
setFeatureLevel((short) 7), (short) 0));
static class BootstrapTestDirectory implements AutoCloseable {
- File directory = null;
+ private final Path directory;
- synchronized BootstrapTestDirectory createDirectory() {
- directory = TestUtils.tempDirectory("BootstrapTestDirectory");
- return this;
+ static synchronized BootstrapTestDirectory createDirectory() {
+ return new BootstrapTestDirectory();
}
Review Comment:
This was here originally from the already committed stand alone
BootstrapTestDirectory file whose contents I copied over to
BootstrapMetadataTest. I'll make this change as I agree, not sure why this was
synchronized before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
