chia7712 commented on code in PR #21771:
URL: https://github.com/apache/kafka/pull/21771#discussion_r3245005956
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -660,29 +692,38 @@ public static Properties evaluate(
return effective;
}
+ /**
+ * Evaluate group config values to their effective values within
broker-level bounds.
+ * Out-of-range values are capped and a WARN log is emitted.
+ *
+ * @param props The unparsed group config overrides to
modify in place.
Review Comment:
`props` -> `newGroupConfig`
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -804,6 +845,13 @@ private static void evaluateValues(
/**
* Log a WARN if the session timeout is not greater than the heartbeat
interval after
* evaluation. When a key is absent from props, the broker-level default
is used.
+ *
+ * @param props The unparsed group config overrides.
Review Comment:
ditto
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -831,7 +879,7 @@ private static void checkSessionExceedsHeartbeat(
* Clamp a config value to [min, max]. A WARN log is emitted on adjustment.
* No-op when the key is absent from props.
*
- * @param props The properties to modify in place.
+ * @param props The unparsed group config overrides to modify in place.
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
