squah-confluent commented on code in PR #21771:
URL: https://github.com/apache/kafka/pull/21771#discussion_r3246480435
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -660,29 +692,38 @@ public static Properties evaluate(
return effective;
}
+ /**
+ * Evaluate group config values to their effective values within
broker-level bounds.
+ * Out-of-range values are capped and a WARN log is emitted.
+ *
+ * @param newGroupConfig The new unparsed group config overrides
to modify in place.
+ * @param groupId The group id.
+ * @param groupCoordinatorConfig The group coordinator config.
+ * @param shareGroupConfig The share group config.
+ */
private static void evaluateValues(
- Properties props,
+ Properties newGroupConfig,
Review Comment:
Updated again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
