squah-confluent commented on code in PR #22302:
URL: https://github.com/apache/kafka/pull/22302#discussion_r3258407167
##########
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##########
@@ -634,8 +634,14 @@ public Long logRetentionTimeMillis() {
public Map<String, Object> extractGroupConfigMap() {
Map<String, Object> defaults = new HashMap<>();
- GroupConfig.ALL_GROUP_CONFIG_SYNONYMS.forEach((groupConfigName,
brokerConfigName) ->
- brokerConfigName.ifPresent(name -> defaults.put(groupConfigName,
get(name)))
+ Map<String, Object> brokerOriginals = originals();
+ GroupConfig.configNames().forEach(groupConfigName ->
+
GroupConfig.brokerSynonym(groupConfigName).ifPresent(brokerConfigName -> {
+ // Skip internal configs unless they are explicitly configured
via the broker synonym.
+ if (!GroupConfig.isInternal(groupConfigName) ||
brokerOriginals.containsKey(brokerConfigName)) {
Review Comment:
Should we also skip internal broker configs?
What does `DescribeConfigs` do for dynamic, internal broker configs right
now when describing broker configs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
