majialoong commented on code in PR #22302:
URL: https://github.com/apache/kafka/pull/22302#discussion_r3260068317
##########
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##########
@@ -634,8 +634,14 @@ public Long logRetentionTimeMillis() {
public Map<String, Object> extractGroupConfigMap() {
Map<String, Object> defaults = new HashMap<>();
- GroupConfig.ALL_GROUP_CONFIG_SYNONYMS.forEach((groupConfigName,
brokerConfigName) ->
- brokerConfigName.ifPresent(name -> defaults.put(groupConfigName,
get(name)))
+ Map<String, Object> brokerOriginals = originals();
+ GroupConfig.configNames().forEach(groupConfigName ->
+
GroupConfig.brokerSynonym(groupConfigName).ifPresent(brokerConfigName -> {
+ // Skip internal configs unless they are explicitly configured
via the broker synonym.
+ if (!GroupConfig.isInternal(groupConfigName) ||
brokerOriginals.containsKey(brokerConfigName)) {
Review Comment:
Thanks for pointing this out. I don't think we need an additional filter
based on whether the broker synonym itself is internal here.
This method isn't describing broker configs directly; it only maps
broker-level synonyms into group config defaults for the `GROUP`
`DescribeConfigs` path.
For internal broker configs, `DescribeConfigs` will only return them if they
have been explicitly configured by the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
