muralibasani commented on code in PR #22342:
URL: https://github.com/apache/kafka/pull/22342#discussion_r3289227653
##########
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##########
@@ -349,20 +349,24 @@ private static String parseListenerName(String
connectionString) {
* <p>
* This method exists to support migration from kafka.server.KafkaConfig
(Scala/core) to AbstractKafkaConfig (Java/server).
* When migrating code, replace KafkaConfig references with
AbstractKafkaConfig.
+ * Subclasses should override this method to integrate with their dynamic
configuration mechanism;
+ * the default implementation is a no-op.
*
* @param reconfigurable the component to register for configuration
updates
*/
- public abstract void addReconfigurable(Reconfigurable reconfigurable);
Review Comment:
There are currently 5 dependants for this
NodeToControllerChannelManagerImpl, SocketServer,
TransactionMarkerChannelManager, NetworkUtils and BrokerBlockingSender. These
are fine as they have already overriden those methds. But any new classes which
are not overriding would not receive any dynamic updates, (as there will not be
any compile errors, )where they are supposed to ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
