majialoong commented on code in PR #22342:
URL: https://github.com/apache/kafka/pull/22342#discussion_r3289451479
##########
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##########
@@ -349,20 +349,24 @@ private static String parseListenerName(String
connectionString) {
* <p>
* This method exists to support migration from kafka.server.KafkaConfig
(Scala/core) to AbstractKafkaConfig (Java/server).
* When migrating code, replace KafkaConfig references with
AbstractKafkaConfig.
+ * Subclasses should override this method to integrate with their dynamic
configuration mechanism;
+ * the default implementation is a no-op.
*
* @param reconfigurable the component to register for configuration
updates
*/
- public abstract void addReconfigurable(Reconfigurable reconfigurable);
Review Comment:
Good catch. To clarify, the 5 classes you listed are callers of
`addReconfigurable`, not subclasses of `AbstractKafkaConfig`, so this change
doesn't affect them.
Today, the only production subclass is `kafka.server.KafkaConfig`, and it
still overrides both methods by delegating to dynamicConfig.
My understanding is that these methods are transitional for the KAFKA-15853
migration: `AbstractKafkaConfig` is intended to become the future
`KafkaConfig`, so the current dynamicConfig-backed implementation in
KafkaConfig should eventually move here as part of that migration.
Please let me know if my understanding is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
