kevin-wu24 commented on code in PR #22191:
URL: https://github.com/apache/kafka/pull/22191#discussion_r3290478846
##########
core/src/test/scala/unit/kafka/server/ControllerRegistrationManagerTest.scala:
##########
@@ -103,7 +103,8 @@ class ControllerRegistrationManagerTest {
prevImage: MetadataImage,
manager: ControllerRegistrationManager,
metadataVersion: MetadataVersion,
- registrationModifier: RegisterControllerRecord =>
Option[RegisterControllerRecord]
+ registrationModifier: RegisterControllerRecord =>
Option[RegisterControllerRecord],
+ unregisterModifier: UnregisterControllerRecord =>
Option[UnregisterControllerRecord]
Review Comment:
I agree the modifier pattern can be a bit confusing, but I think this is
outside of the scope of this PR. This file will get converted to java at some
point, and maybe after that we can clean this up. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
